Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable custom domain edition only on turbo and legacy spaces #1087

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jan 8, 2025

Summary

Toward https://github.com/snapshot-labs/workflow/issues/362

This PR will enable the custom domain input in the space settings only for:

  • turbo spaces
  • spaces which have setup a custom domain previously (before the move of whitelabel feature to turbo spaces only)

It means that all spaces which have a custom domain actually can continue to edit it, as long as they did not remove it (once removed, it's gone for good)

This change is only for the UI side, another PR will prevent same thing on sequencer (snapshot-labs/snapshot-sequencer#488)

How to test

The custom domain should be editable in the space settings for those spaces:

  1. turbo space without custom domain: http://localhost:8080/#/s:lido-snapshot.eth/settings/advanced
  2. turbo space with custom domain: http://localhost:8080/#/s:balancer.eth/settings/advanced
  3. regular space with existing custom domain: http://localhost:8080/#/s:fabien.eth/settings/advanced

For regular spaces without custom domain, the input should be disabled: http://localhost:8080/#/s:test.wa0x6e.eth/settings/advanced

@wa0x6e wa0x6e marked this pull request as ready for review January 8, 2025 20:06
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@wa0x6e wa0x6e merged commit 572446d into master Jan 9, 2025
2 checks passed
@wa0x6e wa0x6e deleted the fix-enable-space-custom-domain-edition-only-on-turbo branch January 9, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants